Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1979193010: Fix for analyzer-cli and the new SummaryBasedDartSdk 'strongMode' parameter. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for analyzer-cli and the new SummaryBasedDartSdk 'strongMode' parameter. I broke the build :-( R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/048d396f1b7c866ac1546a0006b1c8494c8e91a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-16 21:10:26 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-16 22:00:28 UTC) #2
scheglov
4 years, 7 months ago (2016-05-16 22:03:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
048d396f1b7c866ac1546a0006b1c8494c8e91a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698