Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1979183005: Pass the 'strongMode' flag into SdkSummaryResynthesizer. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass the 'strongMode' flag into SdkSummaryResynthesizer. The code for DDC: DartUriResolver createSdkPathResolver(String sdkPath) { var sdk = new SummaryBasedDartSdk('/path/to/strong.sum', true); return new DartUriResolver(sdk); } R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4419e7f479ed3f4547c465f0360ea30fcef642f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 5 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-16 20:12:54 UTC) #1
Paul Berry
lgtm
4 years, 7 months ago (2016-05-16 20:32:08 UTC) #2
scheglov
4 years, 7 months ago (2016-05-16 20:33:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4419e7f479ed3f4547c465f0360ea30fcef642f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698