Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

Issue 1979183002: Remove OwnPtr::release() calls in core/ (part 3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with trunk. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
index b70983399fc80c427ab0f150e95daa0b5aebae5f..f7af8db05cf741ec0170e36500cca1573c397a66 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
@@ -186,7 +186,7 @@ void InspectorConsoleAgent::sendConsoleMessageToFrontend(ConsoleMessage* console
v8::Local<v8::Value> columns = arguments->argumentCount() > 1 ? arguments->argumentAt(1).v8Value() : v8::Local<v8::Value>();
OwnPtr<protocol::Runtime::RemoteObject> inspectorValue = m_v8Session->wrapTable(context, table, columns);
if (inspectorValue)
- jsonArgs->addItem(inspectorValue.release());
+ jsonArgs->addItem(std::move(inspectorValue));
else
jsonArgs = nullptr;
} else {
@@ -196,11 +196,11 @@ void InspectorConsoleAgent::sendConsoleMessageToFrontend(ConsoleMessage* console
jsonArgs = nullptr;
break;
}
- jsonArgs->addItem(inspectorValue.release());
+ jsonArgs->addItem(std::move(inspectorValue));
}
}
if (jsonArgs)
- jsonObj->setParameters(jsonArgs.release());
+ jsonObj->setParameters(std::move(jsonArgs));
}
if (consoleMessage->callStack())
jsonObj->setStack(consoleMessage->callStack()->buildInspectorObject());
@@ -208,7 +208,7 @@ void InspectorConsoleAgent::sendConsoleMessageToFrontend(ConsoleMessage* console
jsonObj->setMessageId(consoleMessage->messageId());
if (consoleMessage->relatedMessageId())
jsonObj->setRelatedMessageId(consoleMessage->relatedMessageId());
- frontend()->messageAdded(jsonObj.release());
+ frontend()->messageAdded(std::move(jsonObj));
frontend()->flush();
}

Powered by Google App Engine
This is Rietveld 408576698