Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 1979183002: Remove OwnPtr::release() calls in core/ (part 3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with trunk. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
index c501fa3c7f784b68c1bc54347cd1cb6f1063399b..52c53a56774092d34577736fda1b8f66e05b3ac4 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
@@ -121,7 +121,7 @@ static PassOwnPtr<protocol::Animation::AnimationEffect> buildObjectForAnimationE
.setFill(computedTiming.fill())
.setBackendNodeId(DOMNodeIds::idForNode(effect->target()))
.setEasing(easing).build();
- return animationObject.release();
+ return animationObject;
}
static PassOwnPtr<protocol::Animation::KeyframeStyle> buildObjectForStringKeyframe(const StringKeyframe* keyframe)
@@ -133,7 +133,7 @@ static PassOwnPtr<protocol::Animation::KeyframeStyle> buildObjectForStringKeyfra
OwnPtr<protocol::Animation::KeyframeStyle> keyframeObject = protocol::Animation::KeyframeStyle::create()
.setOffset(offset)
.setEasing(keyframe->easing().toString()).build();
- return keyframeObject.release();
+ return keyframeObject;
}
static PassOwnPtr<protocol::Animation::KeyframesRule> buildObjectForAnimationKeyframes(const KeyframeEffect* effect)
@@ -151,7 +151,7 @@ static PassOwnPtr<protocol::Animation::KeyframesRule> buildObjectForAnimationKey
const StringKeyframe* stringKeyframe = toStringKeyframe(keyframe.get());
keyframes->addItem(buildObjectForStringKeyframe(stringKeyframe));
}
- return protocol::Animation::KeyframesRule::create().setKeyframes(keyframes.release()).build();
+ return protocol::Animation::KeyframesRule::create().setKeyframes(std::move(keyframes)).build();
}
PassOwnPtr<protocol::Animation::Animation> InspectorAnimationAgent::buildObjectForAnimation(blink::Animation& animation)
@@ -175,7 +175,7 @@ PassOwnPtr<protocol::Animation::Animation> InspectorAnimationAgent::buildObjectF
m_idToAnimationType.set(id, animationType);
OwnPtr<protocol::Animation::AnimationEffect> animationEffectObject = buildObjectForAnimationEffect(toKeyframeEffect(animation.effect()), animationType == AnimationType::CSSTransition);
- animationEffectObject->setKeyframesRule(keyframeRule.release());
+ animationEffectObject->setKeyframesRule(std::move(keyframeRule));
OwnPtr<protocol::Animation::Animation> animationObject = protocol::Animation::Animation::create()
.setId(id)
@@ -185,11 +185,11 @@ PassOwnPtr<protocol::Animation::Animation> InspectorAnimationAgent::buildObjectF
.setPlaybackRate(animation.playbackRate())
.setStartTime(normalizedStartTime(animation))
.setCurrentTime(animation.currentTime())
- .setSource(animationEffectObject.release())
+ .setSource(std::move(animationEffectObject))
.setType(animationType).build();
if (animationType != AnimationType::WebAnimation)
animationObject->setCssId(createCSSId(animation));
- return animationObject.release();
+ return animationObject;
}
void InspectorAnimationAgent::getPlaybackRate(ErrorString*, double* playbackRate)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698