Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests

Committed: https://crrev.com/c4318b06f8224b25d45a3887c258e1d1d33619dc
Cr-Commit-Position: refs/heads/master@{#394021}

[Takashi Toyoshima, 2016-05-16 04:02:38]

Description was changed from

==========
Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests
==========

to

==========
Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests
==========

[Takashi Toyoshima, 2016-05-16 04:02:38]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org, phajdan.jr@chromium.org

[Takashi Toyoshima, 2016-05-16 04:04:12]

As kinuko suggested, I split this trivial change from
https://codereview.chromium.org/1905873002/
PTAL.

[kinuko, 2016-05-16 04:29:57]

lgtm

[Paweł Hajdan Jr., 2016-05-16 09:55:53]

LGTM

[Takashi Toyoshima, 2016-05-17 02:16:30]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-05-17 02:16:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979173002/1

[commit-bot: I haz the power, 2016-05-17 02:21:27]

Description was changed from

==========
Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests
==========

to

==========
Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests
==========

[commit-bot: I haz the power, 2016-05-17 02:21:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 02:23:11]

Description was changed from

==========
Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests
==========

to

==========
Add WARN_UNUSED_RESULT to bool EmbeddedTestServer::Start()

Like other EmbeddedTestServer methods, e.g. InitializeAndListen(),
Start() is better to have WARN_UNUSED_RESULT attribute to catch
unexpected infrastructure issues on testing.

See https://codereview.chromium.org/1905873002/ in which originally
this change is going to be introduced.

BUG=n/a
TEST=build and run content_browsertests

Committed: https://crrev.com/c4318b06f8224b25d45a3887c258e1d1d33619dc
Cr-Commit-Position: refs/heads/master@{#394021}
==========

[commit-bot: I haz the power, 2016-05-17 02:23:12]

Patchset 1 (id:??) landed as
https://crrev.com/c4318b06f8224b25d45a3887c258e1d1d33619dc
Cr-Commit-Position: refs/heads/master@{#394021}