Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: chrome/chrome_common.gypi

Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_by_platform
Patch Set: Fix comment, per asanka's review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/unverified_download_policy.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_common.gypi
diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi
index 12d4a37742d69f1e7d0eaa9b0a7be17268ed5cd9..b7d112ba8dbf60bf694aa4f34aa5c50fa84797c0 100644
--- a/chrome/chrome_common.gypi
+++ b/chrome/chrome_common.gypi
@@ -210,6 +210,10 @@
'common/extensions/api/input_ime/input_components_handler.cc',
'common/extensions/api/input_ime/input_components_handler.h',
],
+ 'chrome_common_shared_safe_browsing_sources': [
+ 'common/safe_browsing/file_type_policies.cc',
+ 'common/safe_browsing/file_type_policies.h',
+ ],
'chrome_common_full_safe_browsing_sources': [
'common/safe_browsing/binary_feature_extractor.cc',
'common/safe_browsing/binary_feature_extractor.h',
@@ -218,8 +222,6 @@
'common/safe_browsing/binary_feature_extractor_win.cc',
'common/safe_browsing/download_protection_util.cc',
'common/safe_browsing/download_protection_util.h',
- 'common/safe_browsing/file_type_policies.cc',
- 'common/safe_browsing/file_type_policies.h',
'common/safe_browsing/ipc_protobuf_message_macros.h',
'common/safe_browsing/ipc_protobuf_message_null_macros.h',
'common/safe_browsing/mach_o_image_reader_mac.cc',
@@ -541,8 +543,16 @@
'common/media/webrtc_logging_messages.h',
]
}],
+ # Desktop uses full safe-browsing, including download protection
['safe_browsing==1', {
- 'sources': [ '<@(chrome_common_full_safe_browsing_sources)', ],
+ 'sources': [
+ '<@(chrome_common_shared_safe_browsing_sources)',
+ '<@(chrome_common_full_safe_browsing_sources)',
+ ],
+ }],
+ # Android uses only the file_type_policies code.
+ ['safe_browsing==2', {
+ 'sources': ['<@(chrome_common_shared_safe_browsing_sources)', ],
}],
],
'target_conditions': [
« no previous file with comments | « chrome/browser/safe_browsing/unverified_download_policy.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698