chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc - Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_by_platform

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_danger_prompt.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.h » ('j') | chrome/common/safe_browsing/file_type_policies.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

index 30902af17746aa46c8f1be3745ba7477d5306fb7..c6398a6302b656dec2e50156287e62928393579e 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc

@@ -35,6 +35,7 @@

#include "chrome/common/chrome_constants.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/safe_browsing/csd.pb.h"

+#include "chrome/common/safe_browsing/file_type_policies.h"

#include "chrome/test/base/testing_browser_process.h"

#include "chrome/test/base/testing_profile.h"

#include "chrome/test/base/testing_profile_manager.h"

@@ -323,6 +324,9 @@ class LastDownloadFinderTest : public testing::Test {

// Incremented on every download addition to avoid downloads with the same id.

int download_id_;

+ // This manages the lifetime of FileTypePolicies::GlobalInstance()

+ FileTypePoliciesManager file_type_policies_manager_;

};

// Tests that nothing happens if there are no profiles at all.