Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1979103002: Revert of Add rudimentary shelf delegate mus unit test. (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
msw, sadrul, sky
CC:
Ken Rockot(use gerrit already), chromium-reviews, James Cook, kalyank, mfomitchev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add rudimentary shelf delegate mus unit test. (patchset #6 id:180001 of https://codereview.chromium.org/1953893003/ ) Reason for revert: Boo, sorry, looks like they're timing out on the bot :( Original issue's description: > Add rudimentary shelf delegate mus unit test. > > Add simple mash shelf tests: > - ash_sysui (which hosts the shelf) draws a window. > - simple use of ShelfController/ShelfObserver interfaces. > > BUG=557406 > TEST=Tests pass > R=sky@chromium.org > > Committed: https://crrev.com/e3f59d3dfe3ec367a7ba4d2109d41fc6f2784088 > Cr-Commit-Position: refs/heads/master@{#393700} TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=557406 Committed: https://crrev.com/b63fb3d3eca89c99c2f387295f5d22ab32e6a650 Cr-Commit-Position: refs/heads/master@{#393763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -157 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D ash/mus/shelf_delegate_mus_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/unittests_manifest.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
Ken Rockot(use gerrit already)
Created Revert of Add rudimentary shelf delegate mus unit test.
4 years, 7 months ago (2016-05-15 00:36:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979103002/1
4 years, 7 months ago (2016-05-15 00:36:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979103002/1
4 years, 7 months ago (2016-05-15 01:01:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979103002/1
4 years, 7 months ago (2016-05-15 01:31:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979103002/1
4 years, 7 months ago (2016-05-15 02:01:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979103002/1
4 years, 7 months ago (2016-05-15 02:30:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979103002/1
4 years, 7 months ago (2016-05-15 03:00:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-15 03:04:12 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b63fb3d3eca89c99c2f387295f5d22ab32e6a650 Cr-Commit-Position: refs/heads/master@{#393763}
4 years, 7 months ago (2016-05-15 03:05:46 UTC) #10
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-16 22:07:43 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1984723005/ by rockot@chromium.org.

The reason for reverting is: Still need to wait until Friday before we can land
https://codereview.chromium.org/1975073002 and be completely shutdown-race-free,
but a few other lingering races have been fixed since this first landed. Going
to attempt to reland and see if bots are happy..

Powered by Google App Engine
This is Rietveld 408576698