Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: test/browser/language_tests.js

Issue 1979013003: fix #569, cache constants defined in methods (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/browser/language_tests.js
diff --git a/test/browser/language_tests.js b/test/browser/language_tests.js
index 714217abac2aa39ba7e85aa8557820dce310ecd7..c885dff9693e907f9e4f69d09f4c6fe545d3f796 100644
--- a/test/browser/language_tests.js
+++ b/test/browser/language_tests.js
@@ -469,6 +469,10 @@
'codec1_test': fail,
'encoding_test': skip_timeout,
+ // TODO(jmesserly): this is in an inconsistent state between our old and
+ // newer SDKs.
+ 'html_escape_test': skip_fail,
sra1 2016/05/14 19:58:27 maybe just fail so we know when it is fixed.
Jennifer Messerly 2016/05/17 18:04:14 The problem here is it's failing inconsistently. U
+
// TODO(rnystrom): If this test is enabled, karma gets confused and
// disconnects randomly.
'json_lib_test': skip_fail,

Powered by Google App Engine
This is Rietveld 408576698