Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1978993003: Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
CC:
oth, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (patchset #1 id:1 of https://codereview.chromium.org/1974293002/ ) Reason for revert: Causes cctest/test-serialize/SnapshotDataBlobWithWarmup failure on arm64: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/534 Original issue's description: > [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. > > Trying to reland http://crrev.com/1902823002. > > This time some blocks have been shuffled around in the AddStub so that the frame still doesn't get built for the fast path. > > Committed: https://crrev.com/567160122de0bdb78aea79a9faa0dc15a564484c > Cr-Commit-Position: refs/heads/master@{#36251} TBR=bmeurer@chromium.org,rmcilroy@chromium.org,epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2a50c7526d61d479280b7a87d92f9b78e9b8fb11 Cr-Commit-Position: refs/heads/master@{#36255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -240 lines) Patch
M src/code-stubs.h View 12 chunks +11 lines, -23 lines 0 comments Download
M src/code-stubs.cc View 27 chunks +138 lines, -192 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 11 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
Created Revert of [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.
4 years, 7 months ago (2016-05-13 23:48:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978993003/1
4 years, 7 months ago (2016-05-13 23:48:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 23:48:22 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 23:49:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a50c7526d61d479280b7a87d92f9b78e9b8fb11
Cr-Commit-Position: refs/heads/master@{#36255}

Powered by Google App Engine
This is Rietveld 408576698