Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1978983002: Delete stale .js or .err files when generating codegen output. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete stale .js or .err files when generating codegen output. This ensures that, for example, if you fix a test to no longer have errors, then the old ".err" file is removed. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/fc1775847115ab2a92e5d265198fc31e49e5ec90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M test/codegen_test.dart View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-13 21:19:32 UTC) #2
Jennifer Messerly
LGTM
4 years, 7 months ago (2016-05-13 21:43:56 UTC) #3
Bob Nystrom
4 years, 7 months ago (2016-05-13 23:34:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc1775847115ab2a92e5d265198fc31e49e5ec90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698