Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chromecast/browser/media/cast_renderer.cc

Issue 1978973002: Moves video frame callbacks from VideoFrameCompositor to Renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addresses comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/media/cast_renderer.h ('k') | chromecast/renderer/media/cma_renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/media/cast_renderer.cc
diff --git a/chromecast/browser/media/cast_renderer.cc b/chromecast/browser/media/cast_renderer.cc
index 3cd2b9638fab5df09d2d975faa469ea4e52807a8..212efc04fc918d6f0e0a813fb89bd0b1abbc09ec 100644
--- a/chromecast/browser/media/cast_renderer.cc
+++ b/chromecast/browser/media/cast_renderer.cc
@@ -103,7 +103,6 @@ void CastRenderer::Initialize(
demuxer_stream_provider->GetStream(::media::DemuxerStream::VIDEO);
if (video_stream) {
VideoPipelineClient video_client;
- // TODO(alokp): Set VideoPipelineClient::natural_size_changed_cb.
video_client.av_pipeline_client.wait_for_key_cb = base::Bind(
&CastRenderer::OnWaitingForDecryptionKey, weak_factory_.GetWeakPtr());
video_client.av_pipeline_client.eos_cb = base::Bind(
@@ -112,6 +111,8 @@ void CastRenderer::Initialize(
base::Bind(&CastRenderer::OnError, weak_factory_.GetWeakPtr());
video_client.av_pipeline_client.statistics_cb = base::Bind(
&CastRenderer::OnStatisticsUpdate, weak_factory_.GetWeakPtr());
+ video_client.natural_size_changed_cb = base::Bind(
+ &CastRenderer::OnVideoNaturalSizeChange, weak_factory_.GetWeakPtr());
// TODO(alokp): Change MediaPipelineImpl API to accept a single config
// after CmaRenderer is deprecated.
std::vector<::media::VideoDecoderConfig> video_configs;
@@ -206,5 +207,15 @@ void CastRenderer::OnWaitingForDecryptionKey() {
client_->OnWaitingForDecryptionKey();
}
+void CastRenderer::OnVideoNaturalSizeChange(const gfx::Size& size) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+ client_->OnVideoNaturalSizeChange(size);
+}
+
+void CastRenderer::OnVideoOpacityChange(bool opaque) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+ client_->OnVideoOpacityChange(opaque);
+}
+
} // namespace media
} // namespace chromecast
« no previous file with comments | « chromecast/browser/media/cast_renderer.h ('k') | chromecast/renderer/media/cma_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698