Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: media/mojo/services/media_mojo_unittest.cc

Issue 1978973002: Moves video frame callbacks from VideoFrameCompositor to Renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes media_bit_reader_fuzzer link error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/media_mojo_unittest.cc
diff --git a/media/mojo/services/media_mojo_unittest.cc b/media/mojo/services/media_mojo_unittest.cc
index dd835a5b6ca317b55ffa5c6f9dc24402fc8e0fb7..a74b086a4eefe2d212d37677033f2b798da4730d 100644
--- a/media/mojo/services/media_mojo_unittest.cc
+++ b/media/mojo/services/media_mojo_unittest.cc
@@ -39,14 +39,20 @@ const char kSecurityOrigin[] = "http://foo.com";
class MockRendererClient : public interfaces::RendererClient {
public:
- MockRendererClient(){};
- ~MockRendererClient() override{};
+ MockRendererClient() {}
+ ~MockRendererClient() override {}
// interfaces::RendererClient implementation.
MOCK_METHOD2(OnTimeUpdate, void(int64_t time_usec, int64_t max_time_usec));
MOCK_METHOD1(OnBufferingStateChange, void(interfaces::BufferingState state));
MOCK_METHOD0(OnEnded, void());
MOCK_METHOD0(OnError, void());
+ MOCK_METHOD1(OnVideoOpacityChange, void(bool opaque));
+
+ // TODO(alokp): gmock does not support move-only function arguments.
+ // Convert this into MOCK_METHOD after gmock implements this feature.
+ // https://github.com/google/googletest/issues/395
+ void OnVideoNaturalSizeChange(mojo::SizePtr size) override {}
xhwang 2016/05/17 06:24:13 You can define a MOCK_METHOD using non movable typ
alokp 2016/05/17 16:25:49 Acknowledged. I will append this to the comment. I
private:
DISALLOW_COPY_AND_ASSIGN(MockRendererClient);

Powered by Google App Engine
This is Rietveld 408576698