Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978963002: Upgrade to the latest dart:convert. (Closed)

Created:
4 years, 7 months ago by Bob Nystrom
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Upgrade to the latest dart:convert. This fixes html_escape_test as well as codec1_test. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/75c2c8ea2ac6b42cf3100a5fce60d7d6743084ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -346 lines) Patch
M lib/runtime/dart_sdk.js View 42 chunks +159 lines, -163 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion1_test.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M test/codegen/lib/convert/codec2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/lib/convert/html_escape_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/convert/ascii.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M tool/input_sdk/lib/convert/base64.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tool/input_sdk/lib/convert/chunked_conversion.dart View 4 chunks +10 lines, -68 lines 0 comments Download
M tool/input_sdk/lib/convert/codec.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/converter.dart View 3 chunks +14 lines, -15 lines 0 comments Download
M tool/input_sdk/lib/convert/encoding.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/html_escape.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/convert/json.dart View 23 chunks +37 lines, -41 lines 0 comments Download
M tool/input_sdk/lib/convert/line_splitter.dart View 3 chunks +22 lines, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/string_conversion.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tool/input_sdk/lib/convert/utf.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M tool/input_sdk/patch/convert_patch.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +5 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 7 months ago (2016-05-13 20:36:40 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-13 21:23:57 UTC) #3
Bob Nystrom
4 years, 7 months ago (2016-05-13 23:33:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
75c2c8ea2ac6b42cf3100a5fce60d7d6743084ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698