Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1978943002: [MD] Fix detached bookmark bar top separator in hdpi (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Fix detached bookmark bar top separator in hdpi BUG=610359 Committed: https://crrev.com/b603df9a53ad07971acf622b1ed458279421efe7 Cr-Commit-Position: refs/heads/master@{#393740}

Patch Set 1 #

Patch Set 2 : better #

Patch Set 3 : better comment #

Patch Set 4 : iterate on comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
Another way to fix this might be to make the toolbar view draw the bottom ...
4 years, 7 months ago (2016-05-13 21:35:44 UTC) #3
Peter Kasting
LGTM
4 years, 7 months ago (2016-05-14 02:09:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978943002/60001
4 years, 7 months ago (2016-05-14 02:52:40 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-14 20:27:57 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 20:29:29 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b603df9a53ad07971acf622b1ed458279421efe7
Cr-Commit-Position: refs/heads/master@{#393740}

Powered by Google App Engine
This is Rietveld 408576698