Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1978933002: [Layout API] Use layoutViewItem() in Internals (Closed)

Created:
4 years, 7 months ago by pilgrim_google
Modified:
4 years, 7 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use layoutViewItem() in Internals There are several references to FrameView::layoutView() which can be replaced 1-1 with layoutViewItem() instead. No new API methods are required. BUG=499321 Committed: https://crrev.com/79f9c48607d0bd1161ff9c279f7783215e47edf5 Cr-Commit-Position: refs/heads/master@{#393880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 7 months ago (2016-05-13 19:07:04 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-16 16:51:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978933002/1
4 years, 7 months ago (2016-05-16 16:54:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 18:41:06 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:42:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79f9c48607d0bd1161ff9c279f7783215e47edf5
Cr-Commit-Position: refs/heads/master@{#393880}

Powered by Google App Engine
This is Rietveld 408576698