Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java

Issue 1978843002: Change Android activity title from JNI call (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java
diff --git a/platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java b/platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java
index 9389f7220810b458d0075d155087e0d1c37578dd..9e7fee70c55dd461d4ee46d0ad8d3ef085728cb5 100644
--- a/platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java
+++ b/platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java
@@ -8,9 +8,12 @@
package org.skia.viewer;
import android.app.Application;
+import android.util.Log;
djsollen 2016/05/13 14:56:27 unused import
liyuqian 2016/05/13 15:18:41 Done.
public class ViewerApplication extends Application {
private long mNativeHandle = 0;
+ private ViewerActivity mViewerActivity;
+ private String mTitle;
static {
System.loadLibrary("skia_android");
@@ -38,4 +41,24 @@ public class ViewerApplication extends Application {
public long getNativeHandle() {
return mNativeHandle;
}
+
+ public ViewerActivity getViewerActivity() {
djsollen 2016/05/13 14:56:26 remove unused getter
liyuqian 2016/05/13 15:18:41 Done.
+ return mViewerActivity;
+ }
+
+ public void setViewerActivity(ViewerActivity viewerActivity) {
+ this.mViewerActivity = viewerActivity;
+ }
+
+ public void setTitle(String title) {
+ mTitle = title;
+ if (mViewerActivity != null) {
+ mViewerActivity.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ mViewerActivity.setTitle(mTitle);
djsollen 2016/05/13 14:56:27 I would have thought this would be something like.
liyuqian 2016/05/13 15:18:41 I think mViewerActivity.setTitle is equivalent to
+ }
+ });
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698