chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java - Issue 1978833002: [Media, UI] New default large icon in MediaNotification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

Issue 1978833002: [Media, UI] New default large icon in MediaNotification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use 0 as invalid resource id Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

index e146ce0fef7eda285c503de22bee2b85f916f09a..9dd435bd7e92e471b0e708c227e9447efad12f03 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java

@@ -154,6 +154,8 @@ public class CastSessionImpl implements MediaNotificationListener, CastSession {

.setPrivate(isIncognito)

.setActions(MediaNotificationInfo.ACTION_STOP)

.setContentIntent(contentIntent)

+ .setIcon(R.drawable.ic_notification_media_route)

+ .setDefaultLargeIcon(R.drawable.cast_playing_square)

.setId(R.id.presentation_notification)

.setListener(this);

setNotificationMetadata(mNotificationBuilder);

@@ -482,7 +484,6 @@ public class CastSessionImpl implements MediaNotificationListener, CastSession {

private void setNotificationMetadata(MediaNotificationInfo.Builder builder) {

MediaMetadata notificationMetadata = new MediaMetadata("", "", "");

builder.setMetadata(notificationMetadata);

- builder.setIcon(R.drawable.ic_notification_media_route);

if (mCastDevice != null) notificationMetadata.setTitle(mCastDevice.getFriendlyName());