Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 197883025: Remove display() from composited scrolling test, mark as failing (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, Ian Vollick, Julien - ping for review
Visibility:
Public.

Description

Remove display() from composited scrolling test, mark as failing This test is testing some paint-dependent behavior (see issue 353827) and should behave identically whether or not testRunner.display() is called. However, without the testRunner.display() calling into paint, it misses some invalidations that need to be there for correctness. BUG=345027, 353827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/do-not-repaint-if-scrolling-composited-layers.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
enne (OOO)
6 years, 9 months ago (2014-03-19 00:14:20 UTC) #1
jamesr
lgtm
6 years, 9 months ago (2014-03-19 00:18:28 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-19 01:39:41 UTC) #3
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 9 months ago (2014-03-19 01:39:43 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-19 17:03:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/197883025/1
6 years, 9 months ago (2014-03-19 17:04:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 17:06:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 17:06:54 UTC) #8
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-19 17:08:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/197883025/1
6 years, 9 months ago (2014-03-19 17:09:00 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 18:21:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 18:21:02 UTC) #12
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-19 18:22:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/197883025/1
6 years, 9 months ago (2014-03-19 18:22:51 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 19:31:21 UTC) #15
Message was sent while issue was closed.
Change committed as 169575

Powered by Google App Engine
This is Rietveld 408576698