Source/core/css/resolver/FontBuilder.h - Issue 197883021: Initialise raw pointer to null in FontBuilder constructor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/css/resolver/FontBuilder.h

Issue 197883021: Initialise raw pointer to null in FontBuilder constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added unit test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/css/resolver/FontBuilder.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.	3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.

4 * Copyright (C) 2013 Google Inc. All rights reserved.	4 * Copyright (C) 2013 Google Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 107 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
118 // FontDescriptionChangeScope should be the only consumer of this member.	118 // FontDescriptionChangeScope should be the only consumer of this member.

119 // If you're using it, U R DOIN IT WRONG.	119 // If you're using it, U R DOIN IT WRONG.

120 RenderStyle* m_style;	120 RenderStyle* m_style;

121	121

122 // Fontbuilder is responsbile for creating the Font()	122 // Fontbuilder is responsbile for creating the Font()

123 // object on RenderStyle from various other font-related	123 // object on RenderStyle from various other font-related

124 // properties on RenderStyle. Whenever one of those	124 // properties on RenderStyle. Whenever one of those

125 // is changed, FontBuilder tracks the need to update	125 // is changed, FontBuilder tracks the need to update

126 // style->font() with this bool.	126 // style->font() with this bool.

127 bool m_fontDirty;	127 bool m_fontDirty;

	128

	129 friend class FontBuilderTest;

128 };	130 };

129	131

130 }	132 }

131	133

132 #endif	134 #endif

OLD	NEW