Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
197883020:
Fix handling of bidirectional override (Closed)
|
Created:
6 years, 9 months ago by eae Modified:
6 years, 9 months ago Reviewers:
leviw_travelin_and_unemployed CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr. Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionFix handling of bidirectional override
Fix handling of BDO (bidirectional override) elements by explicitly
checking for bidi override in RenderText and using the specified
direction instead of resolving based on content.
R=leviw@chromium.org
BUG=352160
TEST=fast/text/international/bdo-bidi-width.html
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169461
Patch Set 1 #Patch Set 2 : Patch for landing #Patch Set 3 : #
Messages
Total messages: 35 (0 generated)
LGTM. Such magic test expectations. Wow.
The CQ bit was checked by leviw@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on blink_presubmit
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/1
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/20001
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_rel
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197883020/40001
Message was sent while issue was closed.
Change committed as 169461 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
