Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2976)

Unified Diff: cc/trees/layer_tree_host_pixeltest_readback.cc

Issue 197883017: SkColorType instead of (deprecated) SkBitmap::Config (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_pixeltest_readback.cc
diff --git a/cc/trees/layer_tree_host_pixeltest_readback.cc b/cc/trees/layer_tree_host_pixeltest_readback.cc
index e7845359dea29d7313041689fc49db32e3521aa3..e8ad466dfa72633c83b7b164a5239bc501ee9ba1 100644
--- a/cc/trees/layer_tree_host_pixeltest_readback.cc
+++ b/cc/trees/layer_tree_host_pixeltest_readback.cc
@@ -1109,15 +1109,10 @@ class LayerTreeHostReadbackViaCompositeAndReadbackPixelTest
device_viewport_copy_rect.Intersect(device_viewport_copy_subrect_);
scoped_ptr<SkBitmap> bitmap(new SkBitmap);
- bitmap->setConfig(SkBitmap::kARGB_8888_Config,
- device_viewport_copy_rect.width(),
- device_viewport_copy_rect.height());
- bitmap->allocPixels();
- {
- scoped_ptr<SkAutoLockPixels> lock(new SkAutoLockPixels(*bitmap));
- layer_tree_host()->CompositeAndReadback(bitmap->getPixels(),
- device_viewport_copy_rect);
- }
+ bitmap->allocN32Pixels(device_viewport_copy_rect.width(),
+ device_viewport_copy_rect.height());
+ layer_tree_host()->CompositeAndReadback(bitmap->getPixels(),
Stephen White 2014/03/18 20:14:07 Possibly-dumb question: why do we no longer need a
reed1 2014/03/21 20:49:01 allocPixels (and its helper variants like allocN32
+ device_viewport_copy_rect);
result_bitmap_ = bitmap.Pass();
EndTest();

Powered by Google App Engine
This is Rietveld 408576698