Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: cc/resources/ui_resource_bitmap.cc

Issue 197883017: SkColorType instead of (deprecated) SkBitmap::Config (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments from #5 Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/resources/ui_resource_bitmap.h ('k') | cc/test/fake_scoped_ui_resource.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/ui_resource_bitmap.h" 5 #include "cc/resources/ui_resource_bitmap.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "third_party/skia/include/core/SkBitmap.h" 9 #include "third_party/skia/include/core/SkBitmap.h"
10 #include "third_party/skia/include/core/SkMallocPixelRef.h" 10 #include "third_party/skia/include/core/SkMallocPixelRef.h"
11 #include "third_party/skia/include/core/SkPixelRef.h" 11 #include "third_party/skia/include/core/SkPixelRef.h"
12 12
13 namespace cc { 13 namespace cc {
14 14
15 void UIResourceBitmap::Create(const skia::RefPtr<SkPixelRef>& pixel_ref, 15 void UIResourceBitmap::Create(const skia::RefPtr<SkPixelRef>& pixel_ref,
16 gfx::Size size, 16 const gfx::Size& size,
17 UIResourceFormat format) { 17 UIResourceFormat format) {
18 DCHECK(size.width()); 18 DCHECK(size.width());
19 DCHECK(size.height()); 19 DCHECK(size.height());
20 DCHECK(pixel_ref); 20 DCHECK(pixel_ref);
21 DCHECK(pixel_ref->isImmutable()); 21 DCHECK(pixel_ref->isImmutable());
22 format_ = format; 22 format_ = format;
23 size_ = size; 23 size_ = size;
24 pixel_ref_ = pixel_ref; 24 pixel_ref_ = pixel_ref;
25 25
26 // Default values for secondary parameters. 26 // Default values for secondary parameters.
27 wrap_mode_ = CLAMP_TO_EDGE; 27 wrap_mode_ = CLAMP_TO_EDGE;
28 opaque_ = (format == ETC1); 28 opaque_ = (format == ETC1);
29 } 29 }
30 30
31 UIResourceBitmap::UIResourceBitmap(const SkBitmap& skbitmap) { 31 UIResourceBitmap::UIResourceBitmap(const SkBitmap& skbitmap) {
32 DCHECK_EQ(skbitmap.config(), SkBitmap::kARGB_8888_Config); 32 DCHECK_EQ(skbitmap.colorType(), kPMColor_SkColorType);
33 DCHECK_EQ(skbitmap.width(), skbitmap.rowBytesAsPixels()); 33 DCHECK_EQ(skbitmap.width(), skbitmap.rowBytesAsPixels());
34 DCHECK(skbitmap.isImmutable()); 34 DCHECK(skbitmap.isImmutable());
35 35
36 skia::RefPtr<SkPixelRef> pixel_ref = skia::SharePtr(skbitmap.pixelRef()); 36 skia::RefPtr<SkPixelRef> pixel_ref = skia::SharePtr(skbitmap.pixelRef());
37 const SkImageInfo& info = pixel_ref->info(); 37 const SkImageInfo& info = pixel_ref->info();
38 Create( 38 Create(
39 pixel_ref, gfx::Size(info.fWidth, info.fHeight), UIResourceBitmap::RGBA8); 39 pixel_ref, gfx::Size(info.fWidth, info.fHeight), UIResourceBitmap::RGBA8);
40 40
41 SetOpaque(skbitmap.isOpaque()); 41 SetOpaque(skbitmap.isOpaque());
42 } 42 }
43 43
44 UIResourceBitmap::UIResourceBitmap(const gfx::Size& size, bool is_opaque) {
45 SkAlphaType alphaType = is_opaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType;
46 SkImageInfo info =
47 SkImageInfo::MakeN32(size.width(), size.height(), alphaType);
48 skia::RefPtr<SkPixelRef> pixel_ref = skia::AdoptRef(
49 SkMallocPixelRef::NewAllocate(info, info.minRowBytes(), NULL));
50 pixel_ref->setImmutable();
51 Create(pixel_ref, size, UIResourceBitmap::RGBA8);
52 SetOpaque(is_opaque);
53 }
54
44 UIResourceBitmap::UIResourceBitmap(const skia::RefPtr<SkPixelRef>& pixel_ref, 55 UIResourceBitmap::UIResourceBitmap(const skia::RefPtr<SkPixelRef>& pixel_ref,
45 gfx::Size size) { 56 const gfx::Size& size) {
46 Create(pixel_ref, size, UIResourceBitmap::ETC1); 57 Create(pixel_ref, size, UIResourceBitmap::ETC1);
47 } 58 }
48 59
49 UIResourceBitmap::~UIResourceBitmap() {} 60 UIResourceBitmap::~UIResourceBitmap() {}
50 61
51 AutoLockUIResourceBitmap::AutoLockUIResourceBitmap( 62 AutoLockUIResourceBitmap::AutoLockUIResourceBitmap(
52 const UIResourceBitmap& bitmap) : bitmap_(bitmap) { 63 const UIResourceBitmap& bitmap) : bitmap_(bitmap) {
53 bitmap_.pixel_ref_->lockPixels(); 64 bitmap_.pixel_ref_->lockPixels();
54 } 65 }
55 66
56 AutoLockUIResourceBitmap::~AutoLockUIResourceBitmap() { 67 AutoLockUIResourceBitmap::~AutoLockUIResourceBitmap() {
57 bitmap_.pixel_ref_->unlockPixels(); 68 bitmap_.pixel_ref_->unlockPixels();
58 } 69 }
59 70
60 const uint8_t* AutoLockUIResourceBitmap::GetPixels() const { 71 const uint8_t* AutoLockUIResourceBitmap::GetPixels() const {
61 return static_cast<const uint8_t*>(bitmap_.pixel_ref_->pixels()); 72 return static_cast<const uint8_t*>(bitmap_.pixel_ref_->pixels());
62 } 73 }
63 74
64 } // namespace cc 75 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/ui_resource_bitmap.h ('k') | cc/test/fake_scoped_ui_resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698