Add browsertest for the feedback service

chrome/browser/download/download_test_file_activity_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_test_file_activity_observer.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 
 namespace content {
 class DownloadItem;
 }
 
 // Test ChromeDownloadManagerDelegate that controls whether how file chooser
 // dialogs are handled, and how files are opend.
 // By default, file chooser dialogs are disabled.
 class DownloadTestFileActivityObserver::MockDownloadManagerDelegate
     : public ChromeDownloadManagerDelegate {
  public:
   explicit MockDownloadManagerDelegate(Profile* profile)
       : ChromeDownloadManagerDelegate(profile),
         file_chooser_enabled_(false),
         file_chooser_displayed_(false),
+        mark_downloads_dangerous_(false),
+        global_danger_type_(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS),
         weak_ptr_factory_(this) {
     if (!profile->IsOffTheRecord())
       GetDownloadIdReceiverCallback().Run(
           content::DownloadItem::kInvalidId + 1);
   }
 
   virtual ~MockDownloadManagerDelegate() {}
 
   void EnableFileChooser(bool enable) {
     file_chooser_enabled_ = enable;
   }
 
   bool TestAndResetDidShowFileChooser() {
     bool did_show = file_chooser_displayed_;
     file_chooser_displayed_ = false;
     return did_show;
   }
 
   base::WeakPtr<MockDownloadManagerDelegate> GetWeakPtr() {
     return weak_ptr_factory_.GetWeakPtr();
   }
 
+  void SetDangerTypeForNewDownloads(bool mark_downloads_dangerous,
+                                    content::DownloadDangerType danger_type) {
+    mark_downloads_dangerous_ = mark_downloads_dangerous;
+    global_danger_type_ = danger_type;
+  }
+
+  virtual bool DetermineDownloadTarget(
+      content::DownloadItem* item,
+      const content::DownloadTargetCallback& callback) OVERRIDE {
+    if (mark_downloads_dangerous_ &&
+        item->GetDangerType() != content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS) {

[asanka, 2014/06/05 19:20:12]

Nit: Might be simpler to just route the callback through SetDangerous whenever
mark_downloads_dangerous_ is true.

+      content::DownloadTargetCallback dangerous_callback =
+          base::Bind(&MockDownloadManagerDelegate::SetDangerous,
+                     callback);
+      return ChromeDownloadManagerDelegate::DetermineDownloadTarget(
+          item, dangerous_callback);
+    } else {
+      return ChromeDownloadManagerDelegate::DetermineDownloadTarget(
+          item, callback);
+    }
+  }
+
+  static void SetDangerous(
+      const content::DownloadTargetCallback& callback,
+      const base::FilePath& target_path,
+      content::DownloadItem::TargetDisposition disp,
+      content::DownloadDangerType danger_type,
+      const base::FilePath& intermediate_path) {
+    callback.Run(target_path,
+                 disp,
+                 content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT,
+                 intermediate_path);
+  }
+
  protected:
 
   virtual void PromptUserForDownloadPath(content::DownloadItem* item,
                                          const base::FilePath& suggested_path,
                                          const FileSelectedCallback&
                                              callback) OVERRIDE {
     file_chooser_displayed_ = true;
     base::MessageLoop::current()->PostTask(
         FROM_HERE, base::Bind(callback, (file_chooser_enabled_ ? suggested_path
                                          : base::FilePath())));
   }
 
   virtual void OpenDownload(content::DownloadItem* item) OVERRIDE {}
 
  private:
   bool file_chooser_enabled_;
   bool file_chooser_displayed_;
+  bool mark_downloads_dangerous_;  // Whether the danger type should be changed.
+  content::DownloadDangerType global_danger_type_;

[asanka, 2014/06/05 19:20:12]

Nit: maybe call it "forced_danger_type_" ? Just a suggestion, but I was a bit
confused by the global_ prefix.

   base::WeakPtrFactory<MockDownloadManagerDelegate> weak_ptr_factory_;
 };
 
 DownloadTestFileActivityObserver::DownloadTestFileActivityObserver(
     Profile* profile) {
   scoped_ptr<MockDownloadManagerDelegate> mock_delegate(
       new MockDownloadManagerDelegate(profile));
   test_delegate_ = mock_delegate->GetWeakPtr();
   DownloadServiceFactory::GetForBrowserContext(profile)->
       SetDownloadManagerDelegateForTesting(
           mock_delegate.PassAs<ChromeDownloadManagerDelegate>());
 }
 
 DownloadTestFileActivityObserver::~DownloadTestFileActivityObserver() {
 }
 
 void DownloadTestFileActivityObserver::EnableFileChooser(bool enable) {
   if (test_delegate_.get())
     test_delegate_->EnableFileChooser(enable);
 }
 
 bool DownloadTestFileActivityObserver::TestAndResetDidShowFileChooser() {
   return test_delegate_.get() &&
       test_delegate_->TestAndResetDidShowFileChooser();
 }
+
+void DownloadTestFileActivityObserver::SetDangerTypeForNewDownloads(
+    bool mark_dangerous,
+    content::DownloadDangerType danger_type) {
+  if (test_delegate_.get())
+    test_delegate_->SetDangerTypeForNewDownloads(mark_dangerous, danger_type);
+}