Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 1978823002: S390: [Interpreter] Fix incorrect frame walking in arguments create stubs (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [Interpreter] Fix incorrect frame walking in arguments create stubs Port 40f345416f00761c79b9d2094c2e12e798329935 Original commit message: The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub looked at the function slot in order to skip stub frames and find the JS frame. However, stub frames do not have a function slot (in fact their fixed frame ends one slot before the JS frame's function slot). Therefore, if this location in the stub frame happens to have the function object the create arguments stubs won't skip this frame correctly. Replace this approach with one where the stub is specialized to either skip a frame if required (since there will only ever be one extra frame on Ignition the loop approach isn't necessary). R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/e7a234253ebd19e3a099d3f3929c9239d504d6b7 Cr-Commit-Position: refs/heads/master@{#36252}

Patch Set 1 #

Patch Set 2 : use more kNear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M src/s390/code-stubs-s390.cc View 1 3 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-13 13:42:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978823002/20001
4 years, 7 months ago (2016-05-13 13:42:40 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 14:12:13 UTC) #5
JoranSiu
On 2016/05/13 14:12:13, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-13 17:45:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978823002/20001
4 years, 7 months ago (2016-05-13 18:06:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 18:08:43 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:10:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7a234253ebd19e3a099d3f3929c9239d504d6b7
Cr-Commit-Position: refs/heads/master@{#36252}

Powered by Google App Engine
This is Rietveld 408576698