Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1978803003:
Roll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits). (Closed)
|
Created:
4 years, 7 months ago by michaelbai Modified:
4 years, 7 months ago Reviewers:
Mark Mentovai CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits).
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18..33a43757f6da
$ git log eb46b8c4f..33a43757f --date=short --no-merges --format='%h %ae %s'
33a4375 yunlian@google.com use another elf.h inside the package for common/dwarf/elf_reader
3a58813 yunlian@google.com Use elf.h inside the package.
fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names
f360908 michaelbai@chromium.org Revert "Write adjusted range back to module"
6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h.
4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF.
551d9ed dmaclach@google.com Update to handle dsym files that end with a header.
5af79e1 yunlian@google.com breakpad: fix unittest errors
40e60e2 yunlian@google.com Add debug fission support.
0bc2fc0 vapier@chromium.org macho: fix printf type mismatches
BUG=606972
Committed: https://crrev.com/36cb63da57053f863d403bf97ea6dcec04efa06f
Cr-Commit-Position: refs/heads/master@{#394654}
Patch Set 1 #Patch Set 2 : add new file to gyp and gn #Patch Set 3 : #Patch Set 4 : roll to elf fix #Patch Set 5 : roll to 2nd elf fix #
Messages
Total messages: 34 (17 generated)
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978803003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978803003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978803003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Roll src/breakpad/src/ eb46b8c4f..f36090857 (7 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..f36090857 --date=short --no-merges --format='%h %ae %s' f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ========== to ========== Roll src/breakpad/src/ eb46b8c4f..f36090857 (7 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..f36090857 --date=short --no-merges --format='%h %ae %s' f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ==========
yunlian@, when you elf_reader.cc roll to chromium, there is error
../../breakpad/src/common/dwarf/elf_reader.cc:38:10: fatal error: 'elf.h' file
not found
#include <elf.h>
^
1 error generated.
On 2016/05/13 23:08:56, michaelbai wrote: > yunlian@, when you elf_reader.cc roll to chromium, there is error > > ../../breakpad/src/common/dwarf/elf_reader.cc:38:10: fatal error: 'elf.h' file > not found > #include <elf.h> > ^ > 1 error generated. I will take a look, thanks.
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978803003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978803003/60001
Description was changed from ========== Roll src/breakpad/src/ eb46b8c4f..f36090857 (7 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..f36090857 --date=short --no-merges --format='%h %ae %s' f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ========== to ========== Roll src/breakpad/src/ eb46b8c4f..3a58813e3 (9 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..3a58813e3 --date=short --no-merges --format='%h %ae %s' 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978803003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978803003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll src/breakpad/src/ eb46b8c4f..3a58813e3 (9 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..3a58813e3 --date=short --no-merges --format='%h %ae %s' 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ========== to ========== Roll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..33a43757f --date=short --no-merges --format='%h %ae %s' 33a4375 yunlian@google.com use another elf.h inside the package for common/dwarf/elf_reader 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ==========
michaelbai@chromium.org changed reviewers: + mark@chromium.org
LGTM
The CQ bit was checked by michaelbai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978803003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978803003/80001
Message was sent while issue was closed.
Description was changed from ========== Roll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..33a43757f --date=short --no-merges --format='%h %ae %s' 33a4375 yunlian@google.com use another elf.h inside the package for common/dwarf/elf_reader 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ========== to ========== Roll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..33a43757f --date=short --no-merges --format='%h %ae %s' 33a4375 yunlian@google.com use another elf.h inside the package for common/dwarf/elf_reader 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Roll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..33a43757f --date=short --no-merges --format='%h %ae %s' 33a4375 yunlian@google.com use another elf.h inside the package for common/dwarf/elf_reader 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 ========== to ========== Roll src/breakpad/src/ eb46b8c4f..33a43757f (10 commits). https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/eb46b8c4fa18... $ git log eb46b8c4f..33a43757f --date=short --no-merges --format='%h %ae %s' 33a4375 yunlian@google.com use another elf.h inside the package for common/dwarf/elf_reader 3a58813 yunlian@google.com Use elf.h inside the package. fa38117 ted@mielczarek.org Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names f360908 michaelbai@chromium.org Revert "Write adjusted range back to module" 6cf96c0 dmaclach@google.com Replaced glibc version of elf.h with musl version of elf.h. 4f9bf66 dmaclach@google.com Fixes up dump_syms build on OS X so it works with ELF. 551d9ed dmaclach@google.com Update to handle dsym files that end with a header. 5af79e1 yunlian@google.com breakpad: fix unittest errors 40e60e2 yunlian@google.com Add debug fission support. 0bc2fc0 vapier@chromium.org macho: fix printf type mismatches BUG=606972 Committed: https://crrev.com/36cb63da57053f863d403bf97ea6dcec04efa06f Cr-Commit-Position: refs/heads/master@{#394654} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/36cb63da57053f863d403bf97ea6dcec04efa06f Cr-Commit-Position: refs/heads/master@{#394654} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
