RenderViewImpl::page_id_ isn't initialized for cross-process replacement navigations.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 3239 matching lines @@
       InternalDocumentStateData::FromDocumentState(document_state);
 
   if (document_state->commit_load_time().is_null())
     document_state->set_commit_load_time(Time::Now());
 
   if (internal_data->must_reset_scroll_and_scale_state()) {
     render_view_->webview()->resetScrollAndScaleState();
     internal_data->set_must_reset_scroll_and_scale_state(false);
   }
 
+  const auto& request_params = navigation_state->request_params();

[Charlie Reis, 2016/05/13 19:14:32]

nit: I think it's useful documentation to leave the type
(RequestNavigationParams) here.  There are a lot of params objects floating
around this class, so it's nice to know at a glance.

[Andrey Kraynov, 2016/05/16 08:03:11]

Done.

   bool is_new_navigation = commit_type == blink::WebStandardCommit;
-  if (is_new_navigation) {
+  bool should_init_page_id = render_view_->page_id_ == -1 &&

[Charlie Reis, 2016/05/13 19:14:32]

Let's add a comment above this:

Ensure that we allocate a page ID if this is the first navigation for the page
in this process.  This can happen even when is_new_navigation is false, such as
after a cross-process location.replace navigation.

[Andrey Kraynov, 2016/05/16 08:03:11]

Done.

+                             request_params.page_id == -1 &&
+                             request_params.nav_entry_id != 0 &&
+                             !navigation_state->IsContentInitiated();
+  if (is_new_navigation || should_init_page_id) {
     // We bump our Page ID to correspond with the new session history entry.
     render_view_->page_id_ = render_view_->next_page_id_++;
 
     DCHECK(!navigation_state->common_params().should_replace_current_entry ||
            render_view_->history_list_length_ > 0);
     if (!navigation_state->common_params().should_replace_current_entry) {
       // Advance our offset in session history, applying the length limit.
       // There is now no forward history.
       render_view_->history_list_offset_++;
       if (render_view_->history_list_offset_ >= kMaxSessionHistoryEntries)
         render_view_->history_list_offset_ = kMaxSessionHistoryEntries - 1;
       render_view_->history_list_length_ =
           render_view_->history_list_offset_ + 1;
     }
   } else {
-    const RequestNavigationParams& request_params =
-        navigation_state->request_params();
     if (request_params.nav_entry_id != 0 &&
         !request_params.intended_as_new_entry) {
       // This is a successful session history navigation!
       render_view_->page_id_ = request_params.page_id;
 
       render_view_->history_list_offset_ =
           request_params.pending_history_list_offset;
     }
   }
 
@@ skipping 2855 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content