RenderViewImpl::page_id_ isn't initialized for cross-process replacement navigations.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 435 matching lines @@
   EXPECT_TRUE(WaitForLoadStop(shell2->web_contents()));
 
   EXPECT_EQ(1, shell2->web_contents()->GetController().GetEntryCount());
   EXPECT_EQ(1, RendererHistoryLength(shell2));
 
   // Again, as above, there's no way to access the renderer's notion of the
   // history offset via JavaScript. Checking just the history length, again,
   // will have to suffice.
 }
 
+IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,

[Charlie Reis, 2016/05/13 19:14:31]

Can you put a comment linking to https://crbug.com/611679 before the test?

[Andrey Kraynov, 2016/05/16 08:03:11]

Done.

+                       PageIDUpdatedOnPageReplacement) {
+  NavigationController& controller = shell()->web_contents()->GetController();
+  const GURL page_url = embedded_test_server()->GetURL(
+      "/navigation_controller/simple_page_1.html");
+
+  // Use data scheme first so that the next page will be loaded
+  // in a separate site instance.
+  NavigateToURL(shell(), GURL("data:text/html,page1"));

[Charlie Reis, 2016/05/13 19:14:31]

nit: EXPECT_TRUE

[Andrey Kraynov, 2016/05/16 08:03:11]

Done.

+  EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));

[Charlie Reis, 2016/05/13 19:14:31]

This isn't necessary, since NavigateToURL will wait long enough.

[Andrey Kraynov, 2016/05/16 08:03:11]

Done.

+  EXPECT_EQ(1, controller.GetEntryCount());
+  EXPECT_NE(-1, shell()->web_contents()->GetMaxPageID());
+
+  // Now navigate and replace the current entry.
+  NavigateToURLAndReplace(shell(), page_url);
+  EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
+  EXPECT_EQ(1, controller.GetEntryCount());
+
+  // Page ID should be updated.
+  EXPECT_NE(-1, shell()->web_contents()->GetMaxPageID());
+
+  // Reload the page and verify that we don't hit
+  // a DCHECK in |RenderFrameImpl::NavigateInternal|.
+  controller.Reload(false);
+  EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
+
+  // DCHECK shouldn't be triggered and we should have a valid page ID.
+  EXPECT_NE(-1, shell()->web_contents()->GetMaxPageID());

[Charlie Reis, 2016/05/13 19:14:31]

Also check
EXPECT_TRUE(shell()->web_contents()->GetMainFrame()->IsRenderFrameLive());

[Andrey Kraynov, 2016/05/16 08:03:11]

Done.

+}
+
 namespace {
 
 class NoNavigationsObserver : public WebContentsObserver {
  public:
   // Observes navigation for the specified |web_contents|.
   explicit NoNavigationsObserver(WebContents* web_contents)
       : WebContentsObserver(web_contents) {}
 
  private:
   void DidNavigateAnyFrame(RenderFrameHost* render_frame_host,
@@ skipping 3622 matching lines @@
     // TODO(clamy): Check the post id as well when PlzNavigate handles it
     // properly.
     if (!IsBrowserSideNavigationEnabled())
       EXPECT_NE(-1, frame_entry->post_id());
     EXPECT_FALSE(entry->GetHasPostData());
     EXPECT_EQ(-1, entry->GetPostID());
   }
 }
 
 }  // namespace content