Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978763004: Drag image should always use the real device scale factor (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
dcheng
CC:
dcheng, blink-reviews, chromium-reviews, esprehn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drag image should always use the real device scale factor When emulated, the screen info has emulated values, so we need dedicated method to get non emulated value. BUG=601563 TEST=manual

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978763004/20001
4 years, 7 months ago (2016-05-16 22:41:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 00:31:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978763004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978763004/40001
4 years, 7 months ago (2016-05-18 17:55:07 UTC) #8
oshima
4 years, 7 months ago (2016-05-18 18:02:00 UTC) #11
dcheng
Eh... I'm inclined to wontfix this. This is one-off plumbing for this very particular use ...
4 years, 7 months ago (2016-05-18 18:22:48 UTC) #12
oshima
4 years, 7 months ago (2016-05-19 23:52:23 UTC) #13 
On 2016/05/18 18:22:48, dcheng wrote:
> Eh...
> 
> I'm inclined to wontfix this. This is one-off plumbing for this very
particular
> use case.

okay, closing this for now.

Powered by Google App Engine
This is Rietveld 408576698