Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 197873040: Use the new NSS function to export RSA private keys in PKCS #8 format. (Closed)

Created:
6 years, 9 months ago by wtc
Modified:
6 years, 9 months ago
Reviewers:
eroman, Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use the new PK11_ExportDERPrivateKeyInfo function when using bundled NSS. Update nss_revision to r259440, which includes the following CL: Add PK11_ExportDERPrivateKeyInfo and PK11_ExportPrivKeyInfo. https://codereview.chromium.org/205343004 R=eroman@chromium.org,rsleevi@chromium.org BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259797

Patch Set 1 #

Patch Set 2 : Use the NSS function PK11_ExportDERPrivateKeyInfo #

Patch Set 3 : Update nss_revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/platform_crypto_nss.cc View 1 2 6 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
wtc
Eric: this is just FYI. Patch set 1 is your code. Patch set 2 uses ...
6 years, 9 months ago (2014-03-19 23:38:59 UTC) #1
eroman
Looks good! BTW I have more tests which I will attach shortly to the original ...
6 years, 9 months ago (2014-03-19 23:49:26 UTC) #2
wtc
On 2014/03/19 23:49:26, eroman wrote: > > BTW I have more tests which I will ...
6 years, 9 months ago (2014-03-20 00:03:27 UTC) #3
wtc
This CL is ready. Please review patch set 3.
6 years, 9 months ago (2014-03-26 23:28:58 UTC) #4
eroman
lgtm
6 years, 9 months ago (2014-03-27 00:28:21 UTC) #5
Ryan Sleevi
lgtm
6 years, 9 months ago (2014-03-27 00:52:17 UTC) #6
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 9 months ago (2014-03-27 01:55:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/197873040/40001
6 years, 9 months ago (2014-03-27 01:56:28 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 05:41:31 UTC) #9
Message was sent while issue was closed.
Change committed as 259797

Powered by Google App Engine
This is Rietveld 408576698