Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 197873025: Don't generate keyed store ICs for global proxies. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Don't generate keyed store ICs for global proxies. BUG=352983 LOG=y R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/ic.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-keyed-store-global.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 9 months ago (2014-03-17 17:10:39 UTC) #1
Igor Sheludko
lgtm
6 years, 9 months ago (2014-03-17 17:18:53 UTC) #2
Toon Verwaest
6 years, 9 months ago (2014-03-17 17:19:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698