Issue 197873015: StopCpuProfiling should return non-const CpuProfile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197873015: StopCpuProfiling should return non-const CpuProfile (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne, alph, loislo

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

StopCpuProfiling should return non-const CpuProfile StopCpuProfiling is replaced with StopProfiling which returns non-const CpuProfile which allows to call CpuProfile::Delete on it without const_cast. Also replaced StartCpuProfiling with StartProfiling to have symmetric names for start/stop actions. BUG=v8:3213 LOG=Y R=alph@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19918

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	include/v8-profiler.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

6 years, 9 months ago (2014-03-14 09:26:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19918 (presubmit successful).

Expand Messages | Collapse Messages