Support scoped types in PPAPI IDL.

ppapi/generators/idl_parser.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Parser for PPAPI IDL """
 
 #
 # IDL Parser
 #
@@ skipping 250 matching lines @@
 #
 # Modifier List
 #
 #
   def p_modifiers(self, p):
     """modifiers : comments ext_attr_block"""
     p[0] = ListFromConcat(p[1], p[2])
     if self.parse_debug: DumpReduction('modifiers', p)
 
 #
+# Type reference (with an optional namespace).
+#
+#
+  def p_typeref(self, p):
+    """typeref : SYMBOL

[noelallen_use_chromium, 2014/03/13 16:31:05]

This does not appear to be recursive.  It only supports SYMBOL and SYMBOL.SYMBOL
 what about SYMBOL.SYMBOL.SYMBOL?   See namespace bellow.

[mtomasz, 2014/03/14 00:36:44]

Done.

[Nils Barth (inactive), 2014/03/14 00:41:45]

Good point! (>.<)

Actually, this grammar rule is identical to |namespace_name|,
so we could reuse it,
preferably by renaming it to |scoped_name|.

Chatted with Tomasz, and he noted correctly that it would be
confusing to use |namespace_name| for typeref (since they're
semantically different), but |scoped_name| should be clear.

[Nils Barth (inactive), 2014/03/14 00:52:11]

Discussed offline; syntactically they're the same,
but the grammar is clearer if we say
typeref : SYMBOL
        | namespace_name '.' SYMBOL

...since semantically name.space.type (scope*d* name)
is different from name.space (scop*e* name).

+               | SYMBOL '.' SYMBOL"""
+    p[0] = "".join(p[1:])

[Nils Barth (inactive), 2014/03/13 07:24:54]

Style: '' (single quotes in Python).

[mtomasz, 2014/03/14 00:36:44]

Done.

+    if self.parse_debug: DumpReduction('typeref', p)
+
+#
 # Comments
 #
 # Comments are optional list of C style comment objects.  Comments are returned
 # as a list or None.
 #
   def p_comments(self, p):
     """comments : COMMENT comments
                 | """
     if len(p) > 1:
       child = self.BuildComment('Comment', p, 1)
@@ skipping 312 matching lines @@
     """param_list : '(' param_item param_cont ')'
                   | '(' ')' """
     if len(p) > 3:
       args = ListFromConcat(p[2], p[3])
     else:
       args = []
     p[0] = self.BuildProduction('Callspec', p, 1, args)
     if self.parse_debug: DumpReduction('param_list', p)
 
   def p_param_item(self, p):
-    """param_item : modifiers optional SYMBOL arrays identifier"""
+    """param_item : modifiers optional typeref arrays identifier"""
     typeref = self.BuildAttribute('TYPEREF', p[3])
     children = ListFromConcat(p[1], p[2], typeref, p[4])
     p[0] = self.BuildNamed('Param', p, 5, children)
     if self.parse_debug: DumpReduction('param_item', p)
 
   def p_optional(self, p):
     """optional : OPTIONAL
                 | """
     if len(p) == 2:
       p[0] = self.BuildAttribute('OPTIONAL', True)
@@ skipping 111 matching lines @@
     p[0] = p[2]
     if self.parse_debug: DumpReduction('label_error', p)
 
 
 #
 # Members
 #
 # A member attribute or function of a struct or interface.
 #
   def p_member_attribute(self, p):
-    """member_attribute : modifiers SYMBOL arrays questionmark identifier"""
+    """member_attribute : modifiers typeref arrays questionmark identifier"""
     typeref = self.BuildAttribute('TYPEREF', p[2])
     children = ListFromConcat(p[1], typeref, p[3], p[4])
     p[0] = self.BuildNamed('Member', p, 5, children)
     if self.parse_debug: DumpReduction('attribute', p)
 
   def p_member_function(self, p):
-    """member_function : modifiers static SYMBOL arrays SYMBOL param_list"""
+    """member_function : modifiers static typeref arrays SYMBOL param_list"""
     typeref = self.BuildAttribute('TYPEREF', p[3])
     children = ListFromConcat(p[1], p[2], typeref, p[4], p[6])
     p[0] = self.BuildNamed('Member', p, 5, children)
     if self.parse_debug: DumpReduction('function', p)
 
   def p_static(self, p):
     """static : STATIC
               | """
     if len(p) == 2:
       p[0] = self.BuildAttribute('STATIC', True)
@@ skipping 474 matching lines @@
   errs = ast.GetProperty('ERRORS')
   if errs:
     ErrOut.Log('Found %d error(s).' % errs);
   InfoOut.Log("%d files processed." % len(filenames))
   return errs
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))