runtime/lib/typed_data.dart - Issue 197873005: Recognize _TypedListBase._cid native. Use Lists.copy instead of native _setRange if list is small. …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/typed_data.dart

Issue 197873005: Recognize _TypedListBase._cid native. Use Lists.copy instead of native _setRange if list is small. … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/typed_data.dart

===================================================================

--- runtime/lib/typed_data.dart (revision 33621)

+++ runtime/lib/typed_data.dart (working copy)

@@ -548,7 +548,10 @@

if (from is _TypedListBase) {

if (this.elementSizeInBytes == from.elementSizeInBytes) {

- if (this.buffer._setRange(

+ if ((count < 10) && (from.buffer != this.buffer)) {

+ Lists.copy(from, skipCount, this, start, count);

+ return;

+ } else if (this.buffer._setRange(

start * elementSizeInBytes + this.offsetInBytes,

count * elementSizeInBytes,

from.buffer,

« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »