[Android] Suppress redundant autozoom for nodes already autozoomed

[Android] Suppress redundant autozoom for nodes already autozoomed

Track whether a focused editable node has been autozoom'ed in RenderViewImpl,
suppressing redundant autozoom requests for the same node. Also remove scale and
scroll saving/restoration support when the keyboard is hidden after initial
focus of an editable node.

BUG=345926
TBR=palmer@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257043

[jdduke (slow), 2014-03-12 17:56:31]

aurimas@: PTAL.  I'll add content/renderer owners if you think this reasonable.

[aurimas (slooooooooow), 2014-03-12 18:06:09]

LGTM

https://codereview.chromium.org/197873002/diff/20001/content/browser/android/...
File content/browser/android/content_view_core_impl.cc (left):

https://codereview.chromium.org/197873002/diff/20001/content/browser/android/...
content/browser/android/content_view_core_impl.cc:1545: void
ContentViewCoreImpl::UndoScrollFocusedEditableNodeIntoView(
Remove this in the header file too.

https://codereview.chromium.org/197873002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/197873002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:394:
private final Rect mFocusPreOSKViewportRect = new Rect();
Do we still need this value?

[jdduke (slow), 2014-03-12 18:18:55]

https://codereview.chromium.org/197873002/diff/20001/content/browser/android/...
File content/browser/android/content_view_core_impl.cc (left):

https://codereview.chromium.org/197873002/diff/20001/content/browser/android/...
content/browser/android/content_view_core_impl.cc:1545: void
ContentViewCoreImpl::UndoScrollFocusedEditableNodeIntoView(
On 2014/03/12 18:06:11, aurimas wrote:
> Remove this in the header file too.

Done.

https://codereview.chromium.org/197873002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/197873002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:394:
private final Rect mFocusPreOSKViewportRect = new Rect();
On 2014/03/12 18:06:11, aurimas wrote:
> Do we still need this value?

Unfortunately yes.  Longer term we should use another signalling mechanism to
issue a delayed form focus request, but for now we need it so that the autozoom
uses the OSK-updated viewport size.

[jdduke (slow), 2014-03-12 18:27:38]

jam@: Review for content/renderer/render_view_impl.{cc,h}? It seemed a bit less
racy to track the focus commands there, rather than in the browser, but we could
also listen to the |FocusedNodeChanged| event in ContentViewCore.

[jam, 2014-03-13 20:31:46]

lgtm

[jdduke (slow), 2014-03-13 20:45:31]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-03-13 20:46:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/197873002/40001

[commit-bot: I haz the power, 2014-03-13 21:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 21:19:22]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jdduke (slow), 2014-03-13 22:24:33]

palmer@: Review for content/common/view_messages.h? Thanks.

[jdduke (slow), 2014-03-13 23:22:14]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-03-13 23:22:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/197873002/40001

[commit-bot: I haz the power, 2014-03-14 00:24:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/197873002/40001

[palmer, 2014-03-14 00:39:27]

IPC security LGTM.

[commit-bot: I haz the power, 2014-03-14 06:34:03]

Change committed as 257043