Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py

Issue 1978703002: Factor and simplify generation of the lookup trie used for HTMLLookupTrie. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove newlines Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/scripts.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (C) 2013 Google Inc. All rights reserved. 2 # Copyright (C) 2013 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
11 # copyright notice, this list of conditions and the following disclaimer 11 # copyright notice, this list of conditions and the following disclaimer
12 # in the documentation and/or other materials provided with the 12 # in the documentation and/or other materials provided with the
13 # distribution. 13 # distribution.
14 # * Neither the name of Google Inc. nor the names of its 14 # * Neither the name of Google Inc. nor the names of its
15 # contributors may be used to endorse or promote products derived from 15 # contributors may be used to endorse or promote products derived from
16 # this software without specific prior written permission. 16 # this software without specific prior written permission.
17 # 17 #
18 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 18 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 19 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 20 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 29
30 from itertools import groupby, islice
31 import sys 30 import sys
32 31
33 import in_generator 32 import in_generator
33 import trie_builder
34 import template_expander 34 import template_expander
35 35
36 PARAMETER_NAME = 'data'
37
38
39 def _trie(tags, index):
40 """Make a trie from list of tags, starting at index.
41
42 Resulting trie is partly space-optimized (semi-radix tree): once have only
43 one string left, compact the entire branch to one leaf node.
44 However, does not compact branch nodes with a single child. (FIXME)
45
46 Returns:
47 (char, subtrie, tag, conditions): (char, trie, str, list)
48 code generation differs between branch nodes and leaf nodes,
49 hence need different data for each.
50
51 Arguments:
52 tags: sorted list
53 (sorted needed by groupby, list needed by len)
54 index: index at which to branch
55 (assumes prior to this index strings have a common prefix)
56 """
57 def trie_node(char, subtags_iter):
58 # Pass in |char| so we can include in same tuple without unpacking
59 subtags = list(subtags_iter) # need list for len
60 if len(subtags) == 1: # terminal node, no subtrie
61 subtrie = None
62 tag = subtags[0]
63 conditions = _conditions(tag, index + 1)
64 else:
65 subtrie = _trie(subtags, index + 1)
66 tag = None
67 conditions = None
68 return char, subtrie, tag, conditions
69
70 # Group by char at index
71 def char_at_index(tag):
72 return tag[index].lower()
73
74 char_subtags = ((k, g) for k, g in groupby(tags, char_at_index))
75
76 # FIXME: if all subtags have a common prefix, merge with child
77 # and skip the switch in the generated code
78
79 return (trie_node(char, subtags) for char, subtags in char_subtags)
80
81
82 def _conditions(tag, index):
83 # boolean conditions to check suffix; corresponds to compacting branch
84 # with a single leaf
85 return ["%s[%d] == '%c'" % (PARAMETER_NAME, i, c.lower())
86 for i, c in islice(enumerate(tag), index, None)]
87
88 36
89 class ElementLookupTrieWriter(in_generator.Writer): 37 class ElementLookupTrieWriter(in_generator.Writer):
90 # FIXME: Inherit all these from somewhere. 38 # FIXME: Inherit all these from somewhere.
91 defaults = { 39 defaults = {
92 'JSInterfaceName': None, 40 'JSInterfaceName': None,
93 'constructorNeedsCreatedByParser': None, 41 'constructorNeedsCreatedByParser': None,
94 'constructorNeedsFormElement': None, 42 'constructorNeedsFormElement': None,
95 'interfaceName': None, 43 'interfaceName': None,
96 'noConstructor': None, 44 'noConstructor': None,
97 'runtimeEnabled': None, 45 'runtimeEnabled': None,
98 } 46 }
99 default_parameters = { 47 default_parameters = {
100 'attrsNullNamespace': None, 48 'attrsNullNamespace': None,
101 'export': '', 49 'export': '',
102 'fallbackInterfaceName': '', 50 'fallbackInterfaceName': '',
103 'fallbackJSInterfaceName': '', 51 'fallbackJSInterfaceName': '',
104 'namespace': '', 52 'namespace': '',
105 'namespacePrefix': '', 53 'namespacePrefix': '',
106 'namespaceURI': '', 54 'namespaceURI': '',
107 } 55 }
108 56
109 def __init__(self, in_file_paths): 57 def __init__(self, in_file_paths):
110 super(ElementLookupTrieWriter, self).__init__(in_file_paths) 58 super(ElementLookupTrieWriter, self).__init__(in_file_paths)
111 self._tags = [entry['name'] for entry in self.in_file.name_dictionaries] 59 self._tags = {}
60 for entry in self.in_file.name_dictionaries:
61 self._tags[entry['name']] = entry['name']
112 self._namespace = self.in_file.parameters['namespace'].strip('"') 62 self._namespace = self.in_file.parameters['namespace'].strip('"')
113 self._outputs = { 63 self._outputs = {
114 (self._namespace + 'ElementLookupTrie.h'): self.generate_header, 64 (self._namespace + 'ElementLookupTrie.h'): self.generate_header,
115 (self._namespace + 'ElementLookupTrie.cpp'): self.generate_implement ation, 65 (self._namespace + 'ElementLookupTrie.cpp'): self.generate_implement ation,
116 } 66 }
117 67
118 @template_expander.use_jinja('ElementLookupTrie.h.tmpl') 68 @template_expander.use_jinja('ElementLookupTrie.h.tmpl')
119 def generate_header(self): 69 def generate_header(self):
120 return { 70 return {
121 'namespace': self._namespace, 71 'namespace': self._namespace,
122 } 72 }
123 73
124 @template_expander.use_jinja('ElementLookupTrie.cpp.tmpl') 74 @template_expander.use_jinja('ElementLookupTrie.cpp.tmpl')
125 def generate_implementation(self): 75 def generate_implementation(self):
126 # First sort, so groupby works
127 self._tags.sort(key=lambda tag: (len(tag), tag))
128 # Group tags by length
129 length_tags = ((k, g) for k, g in groupby(self._tags, len))
130
131 return { 76 return {
132 'namespace': self._namespace, 77 'namespace': self._namespace,
133 'length_tries': ((length, _trie(tags, 0)) 78 'length_tries': trie_builder.trie_list_by_str_length(self._tags)
134 for length, tags in length_tags),
135 } 79 }
136 80
137 81
138 if __name__ == '__main__': 82 if __name__ == '__main__':
139 in_generator.Maker(ElementLookupTrieWriter).main(sys.argv) 83 in_generator.Maker(ElementLookupTrieWriter).main(sys.argv)
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/scripts.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698