Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

Issue 197863003: Check consistency of manual trace and finalization dispatching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..be41a60b15132c0e79cceda037573a8612dfced1
--- /dev/null
+++ b/tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp
@@ -0,0 +1,48 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "trace_after_dispatch.h"
+
+namespace WebCore {
+
+static B* toB(A* a) { return static_cast<B*>(a); }
+
+void A::trace(Visitor* visitor)
+{
+ switch (m_type) {
+ case TB:
+ toB(this)->traceAfterDispatch(visitor);
+ break;
+ case TC:
+ static_cast<C*>(this)->traceAfterDispatch(visitor);
+ break;
+ case TD:
+ // Missing static_cast<D*>(this)->traceAfterDispatch(visitor);
+ break;
+ }
+}
+
+void A::traceAfterDispatch(Visitor* visitor)
+{
+}
+
+void B::traceAfterDispatch(Visitor* visitor)
+{
+ visitor->trace(m_a);
+ // Missing A::trace(visitor);
+}
+
+void C::traceAfterDispatch(Visitor* visitor)
+{
+ // Missing visitor->trace(m_a);
+ A::trace(visitor);
+}
+
+void D::traceAfterDispatch(Visitor* visitor)
+{
+ visitor->trace(m_a);
+ Abstract::trace(visitor);
+}
+
+}
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/trace_after_dispatch.h ('k') | tools/clang/blink_gc_plugin/tests/trace_after_dispatch.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698