tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp - Issue 197863003: Check consistency of manual trace and finalization dispatching.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp

Issue 197863003: Check consistency of manual trace and finalization dispatching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ignore_fields.h"	5 #include "non_virtual_trace.h"

6	6

7 namespace WebCore {	7 namespace WebCore {

8	8

	9 void A::trace(Visitor* visitor)

	10 {

	11 }

	12

9 void C::trace(Visitor* visitor)	13 void C::trace(Visitor* visitor)

10 {	14 {

11 // Missing trace of m_one.	15 B::trace(visitor);

12 // Not missing ignored field m_two.

13 }	16 }

14	17

15 }	18 }

OLD	NEW