Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/trace_after_dispatch.cpp

Issue 197863003: Check consistency of manual trace and finalization dispatching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: finalization and considered-abstract Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "trace_after_dispatch.h"
6
7 namespace WebCore {
8
9 static B* toB(A* a) { return static_cast<B*>(a); }
10
11 void A::trace(Visitor* visitor)
12 {
13 switch (m_type) {
14 case TB: toB(this)->traceAfterDispatch(visitor);
Mads Ager (chromium) 2014/03/18 09:19:32 break!
zerny-chromium 2014/03/18 10:03:41 Done.
15 case TC: static_cast<C*>(this)->traceAfterDispatch(visitor);
16 case TD: ; // Missing static_cast<D*>(this)->traceAfterDispatch(visitor);
17 }
18 }
19
20 void A::traceAfterDispatch(Visitor* visitor)
21 {
22 }
23
24 void B::traceAfterDispatch(Visitor* visitor)
25 {
26 visitor->trace(m_a);
27 // Missing A::trace(visitor);
28 }
29
30 void C::traceAfterDispatch(Visitor* visitor)
31 {
32 // Missing visitor->trace(m_a);
33 A::trace(visitor);
34 }
35
36 void D::traceAfterDispatch(Visitor* visitor)
37 {
38 visitor->trace(m_a);
39 Abstract::trace(visitor);
40 }
41
42 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698