tools/clang/blink_gc_plugin/tests/finalize_after_dispatch.txt - Issue 197863003: Check consistency of manual trace and finalization dispatching.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/finalize_after_dispatch.txt

Issue 197863003: Check consistency of manual trace and finalization dispatching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: finalization and considered-abstract Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 In file included from finalize_after_dispatch.cpp:5:

	2 ./finalize_after_dispatch.h:12:1: warning: [blink-gc] Class 'NeedsFinalize' is m issing manual finalize dispatch.

	3 class NeedsFinalize : public GarbageCollectedFinalized<NeedsFinalize> {

	4 ^

	5 finalize_after_dispatch.cpp:24:1: warning: [blink-gc] Missing dispatch to class 'D' in manual finalize dispatch.

	6 void A::finalize()

	7 ^

	8 2 warnings generated.

OLD	NEW