Check consistency of manual trace and finalization dispatching.

tools/clang/blink_gc_plugin/tests/finalize_after_dispatch.cpp

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "finalize_after_dispatch.h"
+
+namespace WebCore {
+
+static B* toB(A* a) { return static_cast<B*>(a); }
+
+void A::trace(Visitor* visitor)
+{
+    switch (m_type) {
+    case TB: toB(this)->traceAfterDispatch(visitor);

[Mads Ager (chromium), 2014/03/18 09:19:32]

I think you want some breaks here so that you do not fall through?

Could you format these switch statements in the more usual way:

case TC:
    abc();
    break;
case TD:
    def();
    break;

[zerny-chromium, 2014/03/18 10:03:41]

Yes. I should avoid writing bad/invalid code in test even though they are never
run.

+    case TC: static_cast<C*>(this)->traceAfterDispatch(visitor);
+    case TD: static_cast<D*>(this)->traceAfterDispatch(visitor);
+    }
+}
+
+void A::traceAfterDispatch(Visitor* visitor)
+{
+}
+
+void A::finalize()
+{
+    switch (m_type) {
+    case TB: toB(this)->~B();

[Mads Ager (chromium), 2014/03/18 09:19:32]

break!

[zerny-chromium, 2014/03/18 10:03:41]

Done.

+    case TC: static_cast<C*>(this)->~C();
+    case TD: ; // Missing static_cast<D*>(this)->~D();
+    }
+}
+
+void B::traceAfterDispatch(Visitor* visitor)
+{
+    visitor->trace(m_a);
+    A::trace(visitor);
+}
+
+void C::traceAfterDispatch(Visitor* visitor)
+{
+    visitor->trace(m_a);
+    A::trace(visitor);
+}
+
+void D::traceAfterDispatch(Visitor* visitor)
+{
+    visitor->trace(m_a);
+    Abstract::trace(visitor);
+}
+
+}