Lint to detect dangling identifiers in docs (#240).

Lint to detect dangling identifiers in docs (#240).

Implements: https://github.com/dart-lang/linter/issues/240.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/linter/commit/16598488ae006f45edae5ce4809246cfa1ca72c9

[pquitslund, 2016-05-12 20:57:48]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[pquitslund, 2016-05-12 20:57:49]

I don't know but this seems a little too easy...  Am I missing something?

[scheglov, 2016-05-12 21:08:46]

lgtm

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
File lib/src/rules/comment_references.dart (right):

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
lib/src/rules/comment_references.dart:33: void f(int outOfScopeId) { ... }
Should there be a documentation comment that references something not existing?

[Brian Wilkerson, 2016-05-13 14:37:19]

lgtm

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
File lib/src/rules/comment_references.dart (right):

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
lib/src/rules/comment_references.dart:19: identifiers in docs wrapped in
brackets are in-scope.
nit: 'in-scope' --> 'in scope'

[pquitslund, 2016-05-13 21:12:44]

Description was changed from

==========
Lint to detect dangling identifiers in docs (#240).

Implements: https://github.com/dart-lang/linter/issues/240.

BUG=
==========

to

==========
Lint to detect dangling identifiers in docs (#240).

Implements: https://github.com/dart-lang/linter/issues/240.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/linter/commit/16598488ae006f45edae5ce4809246cfa1...
==========

[pquitslund, 2016-05-13 21:12:46]

Committed patchset #1 (id:1) manually as
16598488ae006f45edae5ce4809246cfa1ca72c9 (presubmit successful).

[pquitslund, 2016-05-13 21:13:16]

Thanks!

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
File lib/src/rules/comment_references.dart (right):

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
lib/src/rules/comment_references.dart:19: identifiers in docs wrapped in
brackets are in-scope.
On 2016/05/13 14:37:17, Brian Wilkerson wrote:
> nit: 'in-scope' --> 'in scope'

Done.

https://codereview.chromium.org/1978603003/diff/1/lib/src/rules/comment_refer...
lib/src/rules/comment_references.dart:33: void f(int outOfScopeId) { ... }
On 2016/05/12 21:08:46, scheglov wrote:
> Should there be a documentation comment that references something not
existing?

Acknowledged.