Remove DebuggerEvent. Refactor remaining code.

Remove DebuggerEvent.  Refactor remaining code.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b28b4f7ef63933a89ac7ce9b64c3eb8eb2ff931

[turnidge, 2016-05-12 20:06:04]

turnidge@google.com changed reviewers:
+ hausner@google.com, johnmccutchan@google.com

[turnidge, 2016-05-12 20:06:06]

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/flow_graph_range...
File runtime/vm/flow_graph_range_analysis_test.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/flow_graph_range...
runtime/vm/flow_graph_range_analysis_test.cc:79: #if 0
Ignore this change -- I need it because I am on the most recent xcode.  Will
revert it before I commit.

[hausner, 2016-05-12 20:54:07]

Debugger changes look good to me. Nice cleanup.

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:332: 
Nit: extra blank line.

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger_api_imp...
File runtime/vm/debugger_api_impl.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger_api_imp...
runtime/vm/debugger_api_impl.cc:107: static Dart_PausedEventHandler*
paused_event_handler = NULL;
If these event handlers are no longer needed, I'd add a TODO saying they should
be removed.

[Cutch, 2016-05-12 21:12:22]

LGTM

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2165: ASSERT(Thread::Current()->execution_state() ==
Thread::kThreadInVM);
Nice catch! How did you find this?

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger_api_imp...
File runtime/vm/debugger_api_impl.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger_api_imp...
runtime/vm/debugger_api_impl.cc:107: static Dart_PausedEventHandler*
paused_event_handler = NULL;
On 2016/05/12 20:54:07, hausner wrote:
> If these event handlers are no longer needed, I'd add a TODO saying they
should
> be removed.

@hausner: they are still used by Dartium.

[turnidge, 2016-05-13 15:29:33]

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:332: 
On 2016/05/12 20:54:07, hausner wrote:
> Nit: extra blank line.

Done.

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2165: ASSERT(Thread::Current()->execution_state() ==
Thread::kThreadInVM);
On 2016/05/12 21:12:22, Cutch wrote:
> Nice catch! How did you find this?

We used to call Debugger::AddBreapointAtLine() directly from the unit tests. 
Since the breakpoint was never resolved, we previously wouldn't get to the
TransitionVMToNative in InvokeEventHandler.  I rewrote the code so that these
BreakpointAdded events were making their way further down the chain and we were
taking this transition, so the tests started failing.

[turnidge, 2016-05-13 15:49:35]

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/flow_graph_range...
File runtime/vm/flow_graph_range_analysis_test.cc (right):

https://codereview.chromium.org/1978603002/diff/1/runtime/vm/flow_graph_range...
runtime/vm/flow_graph_range_analysis_test.cc:79: #if 0
On 2016/05/12 20:06:05, turnidge wrote:
> Ignore this change -- I need it because I am on the most recent xcode.  Will
> revert it before I commit.

I fixed the warning I was seeing in the most recent xcode as part of this cl. 
For the record, it was a complaint that shifting a signed negative number is
undefined.

[turnidge, 2016-05-13 16:47:44]

Description was changed from

==========
Remove DebuggerEvent.  Refactor remaining code.

BUG=
==========

to

==========
Remove DebuggerEvent.  Refactor remaining code.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b28b4f7ef63933a89ac7ce9b64c3eb8eb2ff931
==========

[turnidge, 2016-05-13 16:47:46]

Committed patchset #4 (id:60001) manually as
6b28b4f7ef63933a89ac7ce9b64c3eb8eb2ff931 (presubmit successful).