Issue 19786004: skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19786004: skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with… (Closed)

Created:
7 years, 5 months ago by edisonn

Modified:
7 years, 5 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with the result of each diff engine) Committed: https://code.google.com/p/skia/source/detail?r=10194

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	experimental/skpdiff/SkDiffContext.cpp	View		5 chunks	+38 lines, -0 lines	0 comments	Download
	M	experimental/skpdiff/main.cpp	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

edisonn

Committed patchset #1 manually as r10194 (presubmit successful).

7 years, 5 months ago (2013-07-19 17:19:49 UTC) #1

djsollen

7 years, 5 months ago (2013-07-19 17:26:28 UTC) #2

Message was sent while issue was closed.

why was there no review on this? In general I'm not against adding this as a
feature, but it needs to be reviewed. We are making changes to these files in an
effort to get it moved out of experimental and having to rebase and not break
these new features can and will slow things down.

Expand Messages | Collapse Messages