Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978563002: Stop compiling password infobar code on Mac. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, asvitkine+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop compiling password infobar code on Mac. BUG=580535 Committed: https://crrev.com/457c2a664118b7e1dc9f1c8a30f0e139d4f39711 Cr-Commit-Position: refs/heads/master@{#393470}

Patch Set 1 #

Total comments: 2

Patch Set 2 : GN fix #

Patch Set 3 : clean up cocoa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -250 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 5 chunks +26 lines, -61 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 10 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.cc View 4 chunks +1 line, -67 lines 0 comments Download
D chrome/browser/ui/cocoa/infobars/save_password_infobar_controller.mm View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/ui/views/infobars/legacy_infobars_mac.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +4 lines, -12 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
vasilii
Hi Vaclav, please review.
4 years, 7 months ago (2016-05-12 16:06:20 UTC) #2
vabr (Chromium)
Looks great! :) LGTM Vaclav https://codereview.chromium.org/1978563002/diff/1/chrome/browser/password_manager/password_manager_test_base.cc File chrome/browser/password_manager/password_manager_test_base.cc (right): https://codereview.chromium.org/1978563002/diff/1/chrome/browser/password_manager/password_manager_test_base.cc#newcode81 chrome/browser/password_manager/password_manager_test_base.cc:81: class BubbleObserver : public ...
4 years, 7 months ago (2016-05-12 16:19:29 UTC) #3
vasilii
https://codereview.chromium.org/1978563002/diff/1/chrome/browser/password_manager/password_manager_test_base.cc File chrome/browser/password_manager/password_manager_test_base.cc (right): https://codereview.chromium.org/1978563002/diff/1/chrome/browser/password_manager/password_manager_test_base.cc#newcode81 chrome/browser/password_manager/password_manager_test_base.cc:81: class BubbleObserver : public PromptObserver { On 2016/05/12 16:19:29, ...
4 years, 7 months ago (2016-05-12 16:23:30 UTC) #4
vabr (Chromium)
On 2016/05/12 16:23:30, vasilii wrote: > https://codereview.chromium.org/1978563002/diff/1/chrome/browser/password_manager/password_manager_test_base.cc > File chrome/browser/password_manager/password_manager_test_base.cc (right): > > https://codereview.chromium.org/1978563002/diff/1/chrome/browser/password_manager/password_manager_test_base.cc#newcode81 > ...
4 years, 7 months ago (2016-05-12 16:24:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978563002/20001
4 years, 7 months ago (2016-05-12 16:31:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/182093)
4 years, 7 months ago (2016-05-12 16:37:28 UTC) #9
vasilii
sky@chromium.org: Please review changes in chrome/browser/BUILD.gn
4 years, 7 months ago (2016-05-12 16:42:17 UTC) #11
vasilii
Peter, please review chrome/browser/ui/views/infobars/legacy_infobars_mac.cc
4 years, 7 months ago (2016-05-12 17:20:25 UTC) #13
sky
LGTM
4 years, 7 months ago (2016-05-12 17:57:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978563002/40001
4 years, 7 months ago (2016-05-13 08:07:13 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 08:11:50 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 08:13:30 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/457c2a664118b7e1dc9f1c8a30f0e139d4f39711
Cr-Commit-Position: refs/heads/master@{#393470}

Powered by Google App Engine
This is Rietveld 408576698