Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1978533002: Remove SkPicture::hasText() (Closed)

Created:
4 years, 7 months ago by f(malita)
Modified:
4 years, 7 months ago
Reviewers:
dogben, dogben, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -90 lines) Patch
M include/core/SkPicture.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkBigPicture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkBigPicture.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/core/SkMiniRecorder.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkPictureCommon.h View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +0 lines, -65 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
f(malita)
4 years, 7 months ago (2016-05-12 16:48:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978533002/1
4 years, 7 months ago (2016-05-12 16:49:20 UTC) #4
reed1
lgtm
4 years, 7 months ago (2016-05-12 16:56:12 UTC) #6
f(malita)
+Derek & Ben for Android/G3 sanity check.
4 years, 7 months ago (2016-05-12 16:59:37 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 17:05:12 UTC) #11
dogben
lgtm
4 years, 7 months ago (2016-05-12 17:09:14 UTC) #13
djsollen
lgtm
4 years, 7 months ago (2016-05-12 17:52:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978533002/1
4 years, 7 months ago (2016-05-12 17:52:56 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 17:53:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e2e33a74d707b918a0b1063047bbb25ee81ae67

Powered by Google App Engine
This is Rietveld 408576698