Getting the personalization info in chrome://snippets-internals correct.

components/ntp_snippets/ntp_snippets_fetcher.h

Index: components/ntp_snippets/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/ntp_snippets_fetcher.h b/components/ntp_snippets/ntp_snippets_fetcher.h
index b3cd393f8299607eef4b1c212d064b08e861c812..5a159ca27128ae3fe5e33da91c9a247958e2c36d 100644
--- a/components/ntp_snippets/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/ntp_snippets_fetcher.h
@@ -65,6 +65,9 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
     RESULT_MAX
   };
 
+  // Enumaration listing all possible variants of dealing with personalization.

[Bernhard Bauer, 2016/05/18 10:08:03]

"Enumeration"

[jkrcal, 2016/05/19 07:30:28]

Done.

+  enum class Personalization { kPersonal, kNonPersonal, kBoth };

[Bernhard Bauer, 2016/05/18 10:08:04]

Put the values on individual lines :)

[jkrcal, 2016/05/19 07:30:28]

One line is what "git cl format" produces. Should I fight against it? ;)

[Bernhard Bauer, 2016/05/19 08:51:19]

Yeah, it would be nice. I don't think clang-format grasps the concept of trying
to avoid churn when adding more values.

[jkrcal, 2016/05/19 10:58:16]

I am afraid I do not understand. Do you suggest me to put it on separate lines
and _not_ run "git cl format" afterwards?

Is there some way I can force this format to persist in the future (when someone
else calls git cl format)?

[Bernhard Bauer, 2016/05/19 11:05:46]

That is correct. There are areas of the code base that enforce clang-format
cleanness, but this area doesn't, and generally clang-format does not override
style decisions (or the style guide).
Not that I know. (You could try making the names longer of course ;-) )

[jkrcal, 2016/05/19 16:36:24]

Done.

+
   NTPSnippetsFetcher(
       SigninManagerBase* signin_manager,
       OAuth2TokenService* oauth2_token_service,
@@ -95,20 +98,24 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
     return last_fetch_json_;
   }
 
+  // Returns the last json fetched from the server.

[Bernhard Bauer, 2016/05/18 10:08:04]

Nit: JSON

[jkrcal, 2016/05/19 07:30:28]

Done.

+  const Personalization personalization() const { return personalization_; }

[Bernhard Bauer, 2016/05/18 10:08:04]

Const for a return type that is by itself immutable is unnecessary.

[jkrcal, 2016/05/19 07:30:28]

Thanks. Interestingly, it even does not compile on iOS.

+
+  // Does the fetcher use host restriction?
+  bool UseHostRestriction() const;

[Bernhard Bauer, 2016/05/18 10:08:03]

Nit: "host restrictions" (plural). Also, "uses", so it isn't confused with an
imperative.

[jkrcal, 2016/05/19 07:30:28]

Done.

+  // Does the fetcher use authentication to get personalized results?
+  bool UseAuthentication() const;

[Bernhard Bauer, 2016/05/18 10:08:03]

"Uses" here as well.

[jkrcal, 2016/05/19 07:30:28]

Done.

+
   // Overrides internal clock for testing purposes.
   void SetTickClockForTesting(std::unique_ptr<base::TickClock> tick_clock) {
     tick_clock_ = std::move(tick_clock);
   }
 
  private:
-  enum class Personalization { kPersonal, kNonPersonal, kBoth };
-
   void FetchSnippetsImpl(const GURL& url,
                          const std::string& auth_header,
                          const std::string& request);
   std::string GetHostRestricts() const;
-  bool UseHostRestriction() const;
-  bool UseAuthentication() const;
   void FetchSnippetsNonAuthenticated();
   void FetchSnippetsAuthenticated(const std::string& account_id,
                                   const std::string& oauth_access_token);