Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 19785004: Move FindCodeObject from Heap to Isolate. (Closed)

Created:
7 years, 5 months ago by Sven Panne
Modified:
7 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Move FindCodeObject from Heap to Isolate. This removes the isolate=>heap=>isolate nonsense and has the additional bonus that it re-enables printing of code objects in GDB. NOT: To make the latter work, one has to adapt GDB any macros using FindCodeObject! Keeping things as it is and outlining Isolate::heap() was not really an option... Side note: Currently we are lucky that we still have Isolate::Current() available in GDB, although it is marked as INLINE. :-} R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 5 months ago (2013-07-19 09:34:43 UTC) #1
Toon Verwaest
lgtm++
7 years, 5 months ago (2013-07-19 09:38:35 UTC) #2
Sven Panne
7 years, 5 months ago (2013-07-19 09:39:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15770 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698