Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 1978453004: Add GN bots into commit queue (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M infra/config/cq.cfg View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Wei Li
for review, thanks
4 years, 7 months ago (2016-05-12 21:12:50 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1978453004/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1978453004/diff/1/infra/config/cq.cfg#newcode53 infra/config/cq.cfg:53: name: "linux_xfa_rel_gn" Do we want to keep them ...
4 years, 7 months ago (2016-05-12 22:12:03 UTC) #3
Wei Li
thanks https://codereview.chromium.org/1978453004/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1978453004/diff/1/infra/config/cq.cfg#newcode53 infra/config/cq.cfg:53: name: "linux_xfa_rel_gn" On 2016/05/12 22:12:02, Lei Zhang wrote: ...
4 years, 7 months ago (2016-05-12 22:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978453004/1
4 years, 7 months ago (2016-05-12 22:34:05 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 23:02:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f6d9a61af218b7acc1161ae231b16765ca10...

Powered by Google App Engine
This is Rietveld 408576698