Issue 1978453002: [turbofan] Properly initialize mutable heap numbers in literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1978453002: [turbofan] Properly initialize mutable heap numbers in literals. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer

Modified:
4 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1

Target Ref:
refs/pending/branch-heads/5.1

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Properly initialize mutable heap numbers in literals. We accidently drop the effect of the initializing store on the floor and just hang on to the effect of the mutable heap number allocation. This means that the store is actually dead code and will be trimmed from the graph. R=mstarzinger@chromium.org BUG=chromium:610228 NOPRESUBMIT=true NOTRY=true LOG=n

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -29 lines)			Patch
M	src/compiler/js-create-lowering.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/js-create-lowering.cc	View	2 chunks	+11 lines, -19 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-610228.js	View	1 chunk	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978453002/1

4 years, 7 months ago (2016-05-12 12:04:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages